Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments sorted by Last Updated* #4690

Closed
wants to merge 2 commits into from
Closed

Comments sorted by Last Updated* #4690

wants to merge 2 commits into from

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Jan 4, 2024

Fixing the comment sorting to sort by the date they were last updated, not the date they were created at. And updating all the variable names accordingly!

Screenshot 2024-01-04 at 11 57 46 AM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 4, 2024 •
edited
Loading

Job #9724: Bundle Size — 62.19MiB (~-0.01%).

2f1ad7d(current) vs df0030c master#9721(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #9724		      Baseline
Job #9721
Improvement  Initial JS 45.4MiB(~-0.01%) 45.4MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.86% 0%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4361 4361
No change  Duplicate Modules 470 470
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #9724		      Baseline
Job #9721
Improvement  JS 62.18MiB (~-0.01%) 62.18MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9724 report View fix/date-sorting branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as draft January 4, 2024 17:47
@lankaukk lankaukk closed this Feb 8, 2024
@lankaukk lankaukk deleted the fix/date-sorting branch February 8, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lankaukk @gbalint