Give all of the CI jobs sensible timeouts #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
liady and
bkrmendy
gbalint
approved these changes
Jan 4, 2024
Job #9695: Bundle Size — 62.18MiB (~+0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9695 report View chore/gh-workflow-timeouts branch activity |
liady
approved these changes
Jan 4, 2024
|
Performance test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
360 minutes of waiting for a test to finish is too long.
Fix:
I've given all of the jobs more sensible timeouts. For the simpler jobs that should typically take seconds (e.g. posting to Discord) I've set the timeout to be 5m, and for the longer running jobs (e.g. the tests) I've set it to 15m. Those should be aggressive enough but not too aggressive, though we can always tweak them if they become problematic.