Get Remix to work with local webpack. #4679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When loading any project using Remix in the editor with local webpack building the editor, you get a big error about
env
not being defined onundefined
.Cause:
In a function
remixLiveReloadConnect
there's some logic that checksprocess.env.REMIX_DEV_ORIGIN
which webpack turns intoundefined.env.REMIX_DEV_ORIGIN
which fails for fairly obvious reasons.Fix:
This provides a value for the specific case of
process.env.REMIX_DEV_ORIGIN
.Commit Details:
process.env.REMIX_DEV_ORIGIN
.