-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize props passed to a component #4616
Conversation
Job #9556: Bundle Size — 66.23MiB (~+0.01%).
Warning Bundle contains 67 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you introduce a new type InsertableVariable
(as mentioned in one of my comments) so that we can rely on the types to know that insertable variables have the required insert menu information (depth and original name) rather than having to rely on our knowledge about what should have been put in the Record
(and then having to type check and cast that)
Problem:
Currently we don't show props in the "Variables" panel or the top bar.
Fix:
Identify which props were passed to the container and add them, allow inserting them.
If an element is selected inside "Playground" (which defines some props)
And
<Playground>
is being passed some real time valuesWe know to recognize those props are in the scope of the selected element and display them