Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize props passed to a component #4616

Merged
merged 14 commits into from
Dec 12, 2023
Merged

Recognize props passed to a component #4616

merged 14 commits into from
Dec 12, 2023

Conversation

liady
Copy link
Contributor

@liady liady commented Dec 7, 2023

Problem:
Currently we don't show props in the "Variables" panel or the top bar.

Fix:
Identify which props were passed to the container and add them, allow inserting them.

If an element is selected inside "Playground" (which defines some props)

image

And <Playground> is being passed some real time values

image

We know to recognize those props are in the scope of the selected element and display them

image

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Try me

Copy link

relativeci bot commented Dec 7, 2023

Job #9556: Bundle Size — 66.23MiB (~+0.01%).

89acc3e(current) vs 5957b21 master#9554(baseline)

Warning

Bundle contains 67 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9556
     Baseline
Job #9554
Regression  Initial JS 48.36MiB(~+0.01%) 48.36MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.22% 23.6%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4490 4490
No change  Duplicate Modules 480 480
No change  Duplicate Code 30.37% 30.37%
No change  Packages 466 466
No change  Duplicate Packages 67 67
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9556
     Baseline
Job #9554
Regression  JS 66.22MiB (~+0.01%) 66.22MiB
Not changed  HTML 11.32KiB 11.32KiB

View job #9556 reportView feat/prop-vars branch activity

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Performance test results:
(Chart1)
(Chart2)

@liady liady marked this pull request as ready for review December 7, 2023 19:15
@liady liady requested review from Rheeseyb and bkrmendy December 7, 2023 19:17
Copy link
Contributor

@Rheeseyb Rheeseyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you introduce a new type InsertableVariable (as mentioned in one of my comments) so that we can rely on the types to know that insertable variables have the required insert menu information (depth and original name) rather than having to rely on our knowledge about what should have been put in the Record (and then having to type check and cast that)

@liady liady requested a review from Rheeseyb December 11, 2023 13:27
@liady liady requested a review from Rheeseyb December 12, 2023 10:50
@liady liady merged commit d7c916f into master Dec 12, 2023
10 checks passed
@liady liady deleted the feat/prop-vars branch December 12, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants