Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix scenes and commenting #4610

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Dec 6, 2023

Problem:
We store scene id and the remix location with the metadata, but the two concepts were not connected.
I changed our logic the following way:

  • We only store the remix route when the comment is connected to a remix scene.
  • Until now we hid the comment indicator when the active remix route was not the same as the comment route. From now on, we only hide the comment indicator when the route of the remix scene of the comment is on a different route (and that might not be the active route if currently a different scene is active)
  • We only navigate the remix scene of the comment to the comment route when we open the comment (and not all the remix scenes).

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Try me

Copy link

relativeci bot commented Dec 6, 2023

Job #9472: Bundle Size — 66.21MiB (+0.03%).

20b3f80(current) vs 5957b21 master#9471(baseline)

Warning

Bundle contains 67 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 3 regressions
                 Current
Job #9472
     Baseline
Job #9471
Regression  Initial JS 48.34MiB(+0.04%) 48.32MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.67% 57.66%
No change  Chunks 26 26
No change  Assets 30 30
Change  Modules 4489(+0.02%) 4488
Regression  Duplicate Modules 480(+0.21%) 479
Regression  Duplicate Code 30.37%(+0.03%) 30.36%
No change  Packages 466 466
No change  Duplicate Packages 67 67
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9472
     Baseline
Job #9471
Regression  JS 66.2MiB (+0.03%) 66.18MiB
Not changed  HTML 11.32KiB 11.32KiB

View job #9472 reportView feature/connect-remix-scene-to-c... branch activity

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint merged commit 99e9677 into master Dec 6, 2023
13 checks passed
@gbalint gbalint deleted the feature/connect-remix-scene-to-comments branch December 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants