Shadow work #4520
Merged
Shadow work #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #9378: Bundle Size — 66.27MiB (~+0.01%).
Warning Bundle contains 68 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
|
|
Performance test results: |
… into shadow-work
seanparsons
approved these changes
Nov 23, 2023
gbalint
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There were many inconsistencies in the various shadows used in the editor.
Fix:
Now we have a new
shadowStylesobject in the utopia-theme file that unifies the different levels of shadows into a consistent system. All UI elements should be using one of the variants of grounded, low, mid, high, or highest. Each of which make use of 2 box-shadow properties, and a color variable for dark/light mode.Highlights: