Store user info in liveblocks room #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #9233: Bundle Size — 65.58MiB (~+0.01%).
Warning Bundle contains 67 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9233 report View feature/store-name-avatar branch activity |
|
Performance test results: |
bkrmendy
approved these changes
Nov 20, 2023
ruggi
approved these changes
Nov 20, 2023
| @@ -305,7 +289,7 @@ const FollowingOverlay = React.memo(() => { | |||
| } | |||
| }) | |||
|
|
|||
| if (followed == null) { | |||
| if (followed == null || followedUser == null) { | |||
There was a problem hiding this comment.
if followed != null and followedUser == null it would be worth writing something to the console because it should not happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
resolveUsersfunction tocreateRoomContextPresencestores user related persistent information (name, avatar and colorIndex), even though the role of that should be to only show the transient state to of presence.Fix:
Theoretically, we should provide an endpoint which can be used get user information from our backend. However, as a quick solution I decided to store the name/avatar/colorIndex in the Liveblocks room storage.
I deleted all redundant information from liveblocks:
The extra upside of this is that in a single project your color remains the same across presence sessions.