Single wrapper for multiplayer components #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
approved these changes
Nov 20, 2023
Job #9214: Bundle Size — 65.16MiB (+0.01%).
Warning Bundle contains 67 duplicate packages – View duplicate packages Bundle metrics
  
Bundle size by type
View job #9214 report View feat/multiplayer-wrap branch activity |
|
Performance test results: |
# Conflicts: # editor/src/components/canvas/design-panel-root.tsx # editor/src/components/user-bar.tsx
seanparsons
approved these changes
Nov 20, 2023
Rheeseyb
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4510
Problem:
Multiplayer components need a
ClientSideSuspensewrapper and anErrorBoundarywrapper.Fix:
This PR does not change the existing behavior of multiplayer components but wraps them in a shared component that provides both the error boundary and the suspense wrapper, which we can expand later on.