Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store collaborators in the liveblocks room storage #4509

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Nov 17, 2023

Problem:
We need to know who are the users who collaborate on a project.
We don't have sharing permissions, so we don't really have data for that.

Fix:
Let's say collaborators are those users who opened the project at least once. We can store their ids in the liveblocks room storage for that project.

  • Add collaborators to the Liveblocks Storage type.
  • Create a hook to add yourself to the collaborators.
  • Create a hook to get the list of collaborators.

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Try me

Copy link

relativeci bot commented Nov 17, 2023

Job #9202: Bundle Size — 65.15MiB (~+0.01%).

9e57dea(current) vs 5957b21 master#9200(baseline)

Warning

Bundle contains 67 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9202
     Baseline
Job #9200
Regression  Initial JS 47.3MiB(~+0.01%) 47.29MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 23.39% 21.42%
No change  Chunks 25 25
No change  Assets 29 29
No change  Modules 4386 4386
No change  Duplicate Modules 468 468
No change  Duplicate Code 30.38% 30.38%
No change  Packages 454 454
No change  Duplicate Packages 67 67
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9202
     Baseline
Job #9200
Regression  JS 65.14MiB (~+0.01%) 65.14MiB
Not changed  HTML 11.32KiB 11.32KiB

View job #9202 reportView feature/store-collaborators branch activity

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint merged commit 05859eb into master Nov 18, 2023
12 checks passed
@gbalint gbalint deleted the feature/store-collaborators branch November 18, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants