You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It really looks like that the canvas strategies are doing two mistakes that are negating each other:
pushIntendedBoundsAndUpdateGroups([{target: selectedElement,frame: newFrame}],'starting-metadata',// mistake 1. enqueue a follow-up true up by specifying starting-metadata ),
...groupChildren.map((c)=>queueTrueUpElement([trueUpGroupElementChanged(c.elementPath)]),// mistake 2. ONLY for group children (which should already be suspicious that we need this kind of understanding in every strategy!!) then enqueue a _second_ true up that undoes the mistakes of the previous true-up),
These are the two PRs that are responsible for the current situation: #4042 and #4183
I have a feeling that the edge case these two PRs tried to solve is already solved by another system in place...
What I would do is remove the enqueued true ups, and also remove the follow-up queueTrueUpElement from the canvas strategies, and see if we are still breaking any tests.
The text was updated successfully, but these errors were encountered:
as I wrote in #4422
It really looks like that the canvas strategies are doing two mistakes that are negating each other:
These are the two PRs that are responsible for the current situation: #4042 and #4183
I have a feeling that the edge case these two PRs tried to solve is already solved by another system in place...
What I would do is remove the enqueued true ups, and also remove the follow-up queueTrueUpElement from the canvas strategies, and see if we are still breaking any tests.
The text was updated successfully, but these errors were encountered: