Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only enable convert to flex on jsx elements #4375

Merged
merged 3 commits into from
Oct 17, 2023
Merged

only enable convert to flex on jsx elements #4375

merged 3 commits into from
Oct 17, 2023

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Oct 16, 2023 •
edited
Loading

Description

This PR tweaks the shortcut handler for the add/remove flex layout shortcut, so only non-fragment JSX elements are considered. This is consistent with the rest of the editor, since neither fragments nor conditionals have a layout section in their inspector

@bkrmendy bkrmendy changed the title filter only enable convert to flex on jsx elements Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Try me

@relativeci
Copy link

relativeci bot commented Oct 16, 2023 •
edited
Loading

Job #8677: Bundle Size — 63.28MiB (~+0.01%).

2a146b9(current) vs 5957b21 master#8667(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #8677		      Baseline
Job #8667
Regression  Initial JS 35.56MiB(~+0.01%) 35.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.9% 19.83%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4014 4014
No change  Duplicate Modules 455 455
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #8677		      Baseline
Job #8667
Regression  JS 63.27MiB (~+0.01%) 63.27MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8677 report View feature/only-convert-jsx-element... branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy marked this pull request as ready for review October 17, 2023 07:20
@bkrmendy bkrmendy merged commit 523f75b into master Oct 17, 2023
11 checks passed
@bkrmendy bkrmendy deleted the feature/only-convert-jsx-elements-to-flex branch October 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@ruggi ruggi Awaiting requested review from ruggi

@enidemi enidemi Awaiting requested review from enidemi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @balazsbajorics