Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute reparent snapping #4370

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Absolute reparent snapping #4370

merged 3 commits into from
Oct 16, 2023

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Oct 13, 2023 •
edited
Loading

Problem

When reparenting an element into an absolute container, the element doesn't snap to its new parent or siblings.

FIx

Re-apply the fix implemented in #2512, and add tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Try me

@relativeci
Copy link

relativeci bot commented Oct 13, 2023 •
edited
Loading

Job #8662: Bundle Size — 63.27MiB (~-0.01%).

6c51b99(current) vs 5957b21 master#8656(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #8662		      Baseline
Job #8656
Improvement  Initial JS 35.56MiB(~-0.01%) 35.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.89% 0%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4014 4014
No change  Duplicate Modules 455 455
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #8662		      Baseline
Job #8656
Improvement  JS 63.26MiB (~-0.01%) 63.26MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8662 report View fix/absolute-reparent-snapping-2 branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@github-actions
Copy link
Contributor

Performance test results:

@bkrmendy bkrmendy marked this pull request as ready for review October 16, 2023 10:22
@bkrmendy bkrmendy merged commit 89dbc1c into master Oct 16, 2023
12 checks passed
@bkrmendy bkrmendy deleted the fix/absolute-reparent-snapping-2 branch October 16, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@ruggi ruggi Awaiting requested review from ruggi

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@enidemi enidemi Awaiting requested review from enidemi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @Rheeseyb