Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making DefaultNavigatorWidth = GridMenuWidth #4363

Merged
merged 2 commits into from
Oct 12, 2023
Merged

making DefaultNavigatorWidth = GridMenuWidth #4363

merged 2 commits into from
Oct 12, 2023

Conversation

balazsbajorics
Copy link
Contributor

@balazsbajorics balazsbajorics commented Oct 12, 2023 •
edited
Loading

Hah weird I thought this is gonna break a bunch of tests but it doesn't!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Try me

@balazsbajorics balazsbajorics mentioned this pull request Oct 12, 2023
Merged
@relativeci
Copy link

relativeci bot commented Oct 12, 2023 •
edited
Loading

Job #8605: Bundle Size — 63.27MiB (-0.02%).

a508904(current) vs 5957b21 master#8589(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #8605		      Baseline
Job #8589
Improvement  Initial JS 35.55MiB(-0.04%) 35.57MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.78% 18.9%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4016 4016
No change  Duplicate Modules 456 456
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #8605		      Baseline
Job #8589
Improvement  JS 63.26MiB (-0.02%) 63.27MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8605 report View fix/DefaultNavigatorWidth-remova... branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@balazsbajorics balazsbajorics marked this pull request as ready for review October 12, 2023 11:10
ruggi
ruggi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@ruggi ruggi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@balazsbajorics balazsbajorics merged commit fe8fb1b into master Oct 12, 2023
1 check passed
@balazsbajorics balazsbajorics deleted the fix/DefaultNavigatorWidth-removal branch October 12, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruggi ruggi ruggi approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balazsbajorics @gbalint @Rheeseyb @ruggi