Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating the escape hatch fixes the size of the target #4356

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

Rheeseyb
Copy link
Contributor

Problem:
There are cases where converting an element to absolute positioning via the escape hatch (e.g. a reparent or drag) causes the dragged element's width or height to remain a % value, and therefore shrink or grow accordingly. This can be seen by dragging the "drag me" element in this project

Fix:
Whilst we are in many cases fixing the size implicitly via another strategy called as part of this (e.g. the re-parenting in most cases), to ensure that we are always doing so I have explicitly included that size fixing as part of the escape hatch commands, and added the above project as a test project.

To view the fix, try the same project on the branch here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 11, 2023

Job #8567: Bundle Size — 63.28MiB (~+0.01%).

be4e900(current) vs 5957b21 master#8564(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #8567
     Baseline
Job #8564
Regression  Initial JS 35.57MiB(~+0.01%) 35.57MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 18.9% 18.9%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4016 4016
No change  Duplicate Modules 456 456
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #8567
     Baseline
Job #8564
Regression  JS 63.27MiB (~+0.01%) 63.27MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8567 reportView fix/escape-hatch-fixes-size branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Performance test results:
(Chart1)
(Chart2)

@Rheeseyb Rheeseyb merged commit 603552b into master Oct 11, 2023
@Rheeseyb Rheeseyb deleted the fix/escape-hatch-fixes-size branch October 11, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants