Setting hugging parent to fixed is optional when converting to absolute #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #8591: Bundle Size — 63.28MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #8591 report View feature/two-convert-to-absolute-... branch activity |
|
Performance test results: |
gbalint
changed the title
gbalint
requested review from
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
Rheeseyb
reviewed
Oct 11, 2023
.../canvas/canvas-strategies/strategies/convert-to-absolute-and-move-strategy.spec.browser2.tsx
Outdated
Show resolved
Hide resolved
Rheeseyb
reviewed
Oct 11, 2023
.../canvas/canvas-strategies/strategies/convert-to-absolute-and-move-strategy.spec.browser2.tsx
Outdated
Show resolved
Hide resolved
Rheeseyb
reviewed
Oct 11, 2023
Comment on lines
+126
to
+139
| if ( | ||
| !retargetedTargets.every((element) => { | ||
| const elementMetadata = MetadataUtils.findElementByElementPath( | ||
| canvasState.startingMetadata, | ||
| element, | ||
| ) | ||
| return ( | ||
| elementMetadata?.specialSizeMeasurements.position !== 'absolute' && | ||
| honoursPropsPosition(canvasState, element) | ||
| ) | ||
| }) | ||
| ) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
IMO this should also be returning null if this is the set-hugging-parent-to-fixed variant and the parent is not hugging, otherwise we end up providing 2 alternatives to the user that have no difference, which means that when there is a difference between the two the user might not even realise that
Rheeseyb
reviewed
Oct 11, 2023
| return [ | ||
| ...commands, | ||
| ...sizeToVisualDimensions(metadata, pathTree, ancestor), | ||
| showToastCommand('Parent is set to fixed size', 'NOTICE', 'set-parent-to-fixed-size'), |
There was a problem hiding this comment.
I suspect we don't need this toast any more if we're providing this as an explicit option
Rheeseyb
approved these changes
Oct 12, 2023
bkrmendy
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This is a followup PR to #4318
The goal was to make it optional to set the size of a hugging parent to fixed.
Fix:
sizeToVisualDimensions