Only set width/height on zero-size element conversion

[bkrmendy]

Problem

When double-clicking the zero-sized element control on an element that is in a flex parent and has position: absolute set, the flexBasis prop is not taken into account, and the element stays zero-sized on one axis.

FIx

The logic doing the conversion is refactored into two inspector strategies:

1. Convert flex child to non-zero frame
   • applied when the element is in a flex context
   • flex, flexShrink, flexGrow and flexBasis are pruned so they don't interfere with sizing
   • width: 100, height: 100 is added
2. Convert element to non-zero frame
   • width: 100, height: 100 is added
   • if the element is inline, display: inline-block is added

[github-actions]

Try me

[relativeci]

Job #8623: Bundle Size — 63.27MiB (~-0.01%).

e48f6c8(current) vs 5957b21 master#8614(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics   1 change 1 improvement

	Current Job #8623	Baseline Job #8614
Initial JS	35.56MiB(~-0.01%)	35.56MiB
Initial CSS	0B	0B
Cache Invalidation	19.53%	19.53%
Chunks	28	28
Assets	32	32
Modules	4016	4016
Duplicate Modules	456	456
Duplicate Code	31.36%	31.36%
Packages	409	409
Duplicate Packages	64	64

Bundle size by type   1 change 1 improvement

	Current Job #8623	Baseline Job #8614
JS	63.26MiB (~-0.01%)	63.26MiB
HTML	11.54KiB	11.54KiB

---

View job #8623 report View fix/zero-sized-element-remove-ab... branch activity

[github-actions]

Performance test results:

[ruggi]

maybe flip the logic here for an early return or a ternary return

[Rheeseyb]

This looks good, but please hold off on merging until #4360 is complete, as that includes a refactoring of a function sizeToDimensionsFromFrame that it would make sense to use here.

[balazsbajorics]

the new code reads so much better!