Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New toolbar icons #4295

Merged
merged 14 commits into from
Oct 3, 2023
Merged

New toolbar icons #4295

merged 14 commits into from
Oct 3, 2023

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Oct 2, 2023

New Icons in use for the toolbar mode, and the edit mode submenu. The buttons' color/text now changes while hovering instead of its background color changing.

Before Before
Screenshot 2023-10-02 at 4 46 07 PM Screenshot 2023-10-02 at 4 46 26 PM
After After
Screenshot 2023-10-02 at 4 48 04 PM Screenshot 2023-10-02 at 4 47 39 PM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 2, 2023

Job #8369: Bundle Size — 62.79MiB (~+0.01%).

b715650(current) vs 5957b21 master#8364(baseline)

Warning

Bundle contains 64 duplicate packages - View duplicate packages

Bundle metrics (2 changes)
                 Current
Job #8369
     Baseline
Job #8364
Initial JS 35.05MiB(~+0.01%) 35.05MiB
Initial CSS 0B 0B
Cache Invalidation 19.37% 18.39%
Chunks 27 27
Assets 31 31
Modules 3973 3973
Duplicate Modules 424 424
Duplicate Code 30.9% 30.9%
Packages 409 409
Duplicate Packages 64 64
Bundle size by type (1 change)
                 Current
Job #8369
     Baseline
Job #8364
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.77MiB (~+0.01%) 62.77MiB
Media 0B 0B
Other 0B 0B

View job #8369 reportView new-toolbar-icons branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Performance test results:
(Chart1)
(Chart2)

@lankaukk lankaukk marked this pull request as ready for review October 2, 2023 21:17
@Rheeseyb
Copy link
Contributor

Rheeseyb commented Oct 3, 2023

Very nice!

@lankaukk lankaukk merged commit 7cb9001 into master Oct 3, 2023
14 checks passed
@lankaukk lankaukk deleted the new-toolbar-icons branch October 3, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants