Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No overflow inspector row for imgs #4290

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Oct 2, 2023

Description:
Overflow row in the inspector doesn't work really well for imgs, and not very useful neither

Fix:
Disable the overflow row for imgs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Try me

@relativeci
Copy link

relativeci bot commented Oct 2, 2023

Job #8352: Bundle Size — 62.78MiB (~+0.01%).

8323520(current) vs 5957b21 master#8349(baseline)

Warning

Bundle contains 64 duplicate packages - View duplicate packages

Bundle metrics (2 changes)
                 Current
Job #8352
     Baseline
Job #8349
Initial JS 35.05MiB(~+0.01%) 35.05MiB
Initial CSS 0B 0B
Cache Invalidation 19.6% 18.39%
Chunks 27 27
Assets 31 31
Modules 3973 3973
Duplicate Modules 424 424
Duplicate Code 30.9% 30.9%
Packages 409 409
Duplicate Packages 64 64
Bundle size by type (1 change)
                 Current
Job #8352
     Baseline
Job #8349
CSS 0B 0B
Fonts 0B 0B
HTML 11.43KiB 11.43KiB
IMG 0B 0B
JS 62.77MiB (~+0.01%) 62.77MiB
Media 0B 0B
Other 0B 0B

View job #8352 reportView feature/remove-overflow-row-for-... branch activity

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint merged commit b31292b into master Oct 2, 2023
12 checks passed
@gbalint gbalint deleted the feature/remove-overflow-row-for-imgs branch October 2, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants