-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive/complementary constraint resolution for group children #4282
Conversation
Job #8339: Bundle Size — 62.7MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (1 change)
Bundle size by type (1 change)
View job #8339 report View feat/exclusive-constraint-props branch activity |
} | ||
|
||
function maybeRemoveOldestComplement( | ||
set: Set<any>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we set the data-constraints
prop via Utopia, I think it'd be worth it to validate its value getSafeGroupChildConstraintsArray
so that we only take into account the valid values, and ignore whatever else that might have made its way into the prop (and get rid the any
s stemming from getSafeGroupChildConstraintsArray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, done in 6f34c44
(#4282)
Fixes #4281
Problem:
It's possible to over-specify group child constraints, e.g. setting both
left
,right
, andwidth
.Fix: