Ensure containing block around absolute wrapper. #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `fixParentContainingBlockSettings` to check a target and see if a containing block needs to be created around that target by assigning `contain: 'layout'` to the parent. - Implemented `elementHasPositionOf` and `elementHasContainLayout` utility functions. - Hooked `fixParentContainingBlockSettings` into the `WRAP_IN_ELEMENT` action. - Split apart `forElementOptic` into a smaller optic which then gets composed onto to get the new `forElementChildOptic`. - Implemented `propertyHasSimpleValue` utility function.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
Job #8332: Bundle Size — 62.7MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (3 changes)
Bundle size by type (1 change)
View job #8332 report View fix/containing-block-around-abso... branch activity |
|
Performance test results: |
enidemi
approved these changes
Oct 2, 2023
Rheeseyb
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When creating a wrapper element around other elements, if that wrapper includes
position: 'absolute', then that could result in some unexpected layouting.Fix:
When a wrapper element is inserted, if
position: 'absolute'is included in the style properties then if any of the following settings aren't in the parent style props acontain: 'layout'is added to the parent props:position: 'absolute'position: 'relative'contain: 'layout'Commit Details:
fixParentContainingBlockSettingsto check a target and see if a containing block needs to be created around that target by assigningcontain: 'layout'to the parent.elementHasPositionOfandelementHasContainLayoututility functions.fixParentContainingBlockSettingsinto theWRAP_IN_ELEMENTaction.forElementOpticinto a smaller optic which then gets composed onto to get the newforElementChildOptic.propertyHasSimpleValueutility function.