Ensure updating the remix router also updates the navigation data #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
enidemi and
bkrmendy
Job #8337: Bundle Size — 62.7MiB (~+0.01%).
Warning Bundle contains 64 duplicate packages - View duplicate packages Bundle metrics (2 changes)
Bundle size by type (1 change)
View job #8337 report View fix/remix-404-sticking-bug branch activity |
|
Performance test results: |
gbalint
approved these changes
Sep 29, 2023
| ( | ||
| innerRouter: RouterType, | ||
| location: Location, | ||
| updateEntries: 'update-entries' | 'do-not-update-entries', |
There was a problem hiding this comment.
nitpick, but append-to-entries | replace-entries would be much clearer form e
balazsbajorics
approved these changes
Sep 29, 2023
bkrmendy
approved these changes
Oct 2, 2023
seanparsons
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When working on a Remix project, it is possible to get "stuck" on a 404 route (the navigation toolbars stop working) if a change is made to the project whilst one is showing
Fix:
The problem here is that a change to the project's routes will replace the
routerwith a new one, but we weren't updating thenavigationDatawhen this happened, meaning the navigation functions would still be using the previousrouteruntil the new one had triggered any form of navigation. This meant that hitting the "back" button would still call the loader function for the correct route, but then that route would never be rendered since this was happening via arouterthat wasn't being used as the actualRouterProviderfor the remix app.