-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process is not defined using comunica and react without editing the webpack #1097
Comments
Someone will answer your question soon. In the meantime, you might be able to get help more quickly on our Gitter channel. |
I knew there were issues with Are you sure that your installed version of Also including @surilindur in this thread. |
Yes readable-stream in version 4.2.0, so that is not the problem I'm afraid. |
Just looked into this a bit, and it looks like this is a This problem is caused by Even though there are some PRs open to So this boils down to tooling not having decent ESM support yet... @RubenVerborgh Would you be open to making changes to the way AsyncIterator is published? This would allow us to fix this problem without having to wait for those |
Fine with me! And we should definitely also take this to the next major version. |
@RubenVerborgh I was thinking of just publishing ESM files as |
Nah it should be fine; and in any case our default for the next major (which is currently on a fork). |
This fixes issues with the commonly-used create-react-app tool that is unable to handle .cjs files. This change consider CJS by default for .js files, but still exposes ESM for the tools that have proper support for it. See facebook/create-react-app#11889 Closes comunica/comunica#1097
Hello I'm trying to use comunica with a standard react app (created with for example npx create-reactapp my-app) without editing the webpack (when for example npm run eject is used to edit the webpack).
Comunica works perfect with react when you edit the webpack and use "node-polyfil-webpack-plugin". But gives the following error when a standard react app is used:
I'm looking at this problem for a while but can't really figure out how to fix it. I'm currently comparing the 2 app's with each other.
Both use the newest version of comunica. So again, I want to change the code of comunica in order to work, but not that of the react app itself.
I already scoured the internet for this problem, but none really worked.
I've tried to add the following code in App.js:
window.process = {
env: {
NODE_ENV: 'development'
}
}
which solves the issue but gives a new error: process.tick is not defined, so it must be solved in another way.
Any help or tips would be welcome!
The text was updated successfully, but these errors were encountered: