Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable checkstyle #58

Open
manastalukdar opened this issue Jul 29, 2019 · 0 comments
Open

Re-enable checkstyle #58

manastalukdar opened this issue Jul 29, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@manastalukdar
Copy link
Collaborator

At this point CheckStyle seems to provide style guidelines that conflict with Google formatting settings.

Formatting setting:

"java.format.settings.url": "https://raw.githubusercontent.com/google/styleguide/gh-pages/eclipse-java-google-style.xml",
"java.format.settings.profile": "GoogleStyle",

CheckStyle setting:

"java.checkstyle.configuration": "https://raw.githubusercontent.com/checkstyle/checkstyle/master/src/main/resources/google_checks.xml"

Related issue:

Also relevant:

CheckStyle has some breaking changes from 8.18 to 8.23.

The workaround is to change the URL to: https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-8.18/src/main/resources/google_checks.xml
@manastalukdar manastalukdar self-assigned this Jul 29, 2019
@manastalukdar manastalukdar added the bug Something isn't working label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant