Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msPurity spectralMatching issue when polarity filter is on #44

Open
yguitton opened this issue Dec 9, 2020 · 3 comments
Open

msPurity spectralMatching issue when polarity filter is on #44

yguitton opened this issue Dec 9, 2020 · 3 comments

Comments

@yguitton
Copy link
Contributor

yguitton commented Dec 9, 2020

Hi @Tomnl ,

Today, I faced an issue with the spectralMatching tool under W4M. In fact, I think that the polarity filter option is in cause as everything work fine when i juste remove that filter....

Loading required package: Rcpp
Running msPurity spectral matching function for LC-MS(/MS) data
Filter query dataset
Filter library dataset
Error: row value misused
In addition: Warning message:
call dbDisconnect() when finished working with a connection
Execution halted

Do you have a clue?

I have open an issue on our IFB forum, to keep track of the problem.
https://community.france-bioinformatique.fr/t/msms-spectralmatching-issue/855?u=yguitton

All the best

@Tomnl
Copy link
Member

Tomnl commented Dec 10, 2020

Hi @yguitton,

Are you able to share the history so I can check?

You are correct - I think there is a bug on the polarity filter

@yguitton
Copy link
Contributor Author

Hi @Tomnl

the link https://usegalaxy.fr/u/yguitton44/h/xprocessor-test-msms
dataset 245 with error

dataset 246 ok (but no polarity filter)

Thanks for your help

@Tomnl
Copy link
Member

Tomnl commented Dec 10, 2020

The error is when a user selects more one option selected for the polarity.

Will work fine if you use just select 'positive' or just 'negative' see https://usegalaxy.fr/u/tomnl/h/imported-miniporcblatpos-msms

I will look into making the fix.

Thanks for spotting it
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants