Add validation window for avoiding recomputing embeddings #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @constantinpape, This looks like it's working as expected (I tested it on 2d annotator). Let me know how it looks! (thanks for the suggestions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses to take care of misclicks over 'compute embeddings' button, by checking whether or not the embeddings have been precomputed and loaded as well.
I am missing something:
__call__) (I'll have a closer look at this)@constantinpape Does the implementation look as expected? (I tested it via 2d annotator and does the job as expected - besides the aforementioned point)
If this works, should resolve #787.