From e7819f743d0269ff58314cda57164ba7b2ca2e89 Mon Sep 17 00:00:00 2001
From: olayiwola-compucorp <olayiwola@compucorp.co.uk>
Date: Tue, 12 Dec 2023 10:23:31 +0100
Subject: [PATCH] MMB-302: Add help text to certificate download type field

---
 CRM/Certificate/Form/CertificateConfigure.php |  2 +-
 .../Certificate/Form/CertificateConfigure.hlp | 46 ++++++++++---------
 2 files changed, 26 insertions(+), 22 deletions(-)

diff --git a/CRM/Certificate/Form/CertificateConfigure.php b/CRM/Certificate/Form/CertificateConfigure.php
index 97c8ec5..dc11a71 100644
--- a/CRM/Certificate/Form/CertificateConfigure.php
+++ b/CRM/Certificate/Form/CertificateConfigure.php
@@ -180,7 +180,7 @@ public function buildQuickForm() {
       ],
     ]);
 
-    $elementWithHelpTexts = ['relationship_types', 'min_valid_from_date', 'max_valid_through_date'];
+    $elementWithHelpTexts = ['relationship_types', 'min_valid_from_date', 'max_valid_through_date', 'download_type'];
 
     $this->assign('help', $elementWithHelpTexts);
     $this->assign('elementNames', $this->getRenderableElementNames());
diff --git a/templates/CRM/Certificate/Form/CertificateConfigure.hlp b/templates/CRM/Certificate/Form/CertificateConfigure.hlp
index aff6fdc..3b0612c 100644
--- a/templates/CRM/Certificate/Form/CertificateConfigure.hlp
+++ b/templates/CRM/Certificate/Form/CertificateConfigure.hlp
@@ -1,19 +1,19 @@
-{htxt id="relationship_types-title"}
-  {ts}Download Related Contact Certificates{/ts}
-{/htxt}
-{htxt id="relationship_types"}
-  <p>{ts}Contacts who have a CMS user account can download their own CiviCRM certificates, normally from the CiviCRM self service "dashboard", but also from a download certificate.With this setting you can specify contacts who can also download certificates for related contacts based on holding specific relationship types. This might be useful where, for example, a user should be able to download certificates for an organisation record for which they are the main billing contact, or for a partner or spouse. Where no relationship is selected, users will not be able to download certificates from related contacts.{/ts}</p>
-  <p>{ts}<b>Note:</b> This setting has security implications.
-    <br/>System should allow the contacts having this permission to access and download the certificates.{/ts}</p>
-{/htxt}
+{htxt id="relationship_types-title"}
+  {ts}Download Related Contact Certificates{/ts}
+{/htxt}
+{htxt id="relationship_types"}
+  <p>{ts}Contacts who have a CMS user account can download their own CiviCRM certificates, normally from the CiviCRM self service "dashboard", but also from a download certificate.With this setting you can specify contacts who can also download certificates for related contacts based on holding specific relationship types. This might be useful where, for example, a user should be able to download certificates for an organisation record for which they are the main billing contact, or for a partner or spouse. Where no relationship is selected, users will not be able to download certificates from related contacts.{/ts}</p>
+  <p>{ts}<b>Note:</b> This setting has security implications.
+    <br/>System should allow the contacts having this permission to access and download the certificates.{/ts}</p>
+{/htxt}
 
-{htxt id="min_valid_from_date-title"}
-  {ts}Min Valid From Date{/ts}
-{/htxt}
-{htxt id="min_valid_from_date"}
+{htxt id="min_valid_from_date-title"}
+  {ts}Min Valid From Date{/ts}
+{/htxt}
+{htxt id="min_valid_from_date"}
   <p>{ts}The Min and Max Valid Date fields do 2 things: {/ts}</p>
   <ol>
-    <li>
+    <li>
       <p>{ts}<b>Tokens:</b> They will create tokens that can be used on certificates as follows:{/ts}</p>
       <ul>
         <li>
@@ -29,16 +29,16 @@
     <li>
       <p>{ts}<b>Access:</b> It will also only allow users to download the certificate if their membership is valid during the validity period of the certificate. For example if a membership ends on or after the start date or a membership starts before the end date.{/ts}</p>
     </li>
-  <ol>
-{/htxt}
+  <ol>
+{/htxt}
 
-{htxt id="max_valid_through_date-title"}
-  {ts}Max Valid Through Date{/ts}
-{/htxt}
-{htxt id="max_valid_through_date"}
+{htxt id="max_valid_through_date-title"}
+  {ts}Max Valid Through Date{/ts}
+{/htxt}
+{htxt id="max_valid_through_date"}
   <p>{ts}The Min and Max Valid Date fields do 2 things: {/ts}</p>
   <ol>
-    <li>
+    <li>
       <p>{ts}<b>Tokens:</b> They will create tokens that can be used on certificates as follows:{/ts}</p>
       <ul>
         <li>
@@ -54,5 +54,9 @@
     <li>
       <p>{ts}<b>Access:</b> It will also only allow users to download the certificate if their membership is valid during the validity period of the certificate. For example if a membership ends on or after the start date or a membership starts before the end date.{/ts}</p>
     </li>
-  <ol>
+  <ol>
+{/htxt}
+
+{htxt id="download_type"}
+  {ts}Specify whether the certificate should be generated dynamically from a CiviCRM message template or be granted access to a downloadable file.{/ts}
 {/htxt}
\ No newline at end of file