Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micca/tp/_cutadapt.py :: CutadaptError :: inactive #18

Open
EricDeveaud opened this issue Aug 20, 2019 · 0 comments
Open

micca/tp/_cutadapt.py :: CutadaptError :: inactive #18

EricDeveaud opened this issue Aug 20, 2019 · 0 comments
Labels

Comments

@EricDeveaud
Copy link

as code in micca/tp/_cutadapt.py for CutadaptError is just

class CutadaptError(Exception):
    pass

when cutadapt is not found by distutils find_executable, this code don't do nothing.

def _cutadapt_cmd(params):
    cutadapt_bin = find_executable("cutadapt")
    if cutadapt_bin is None:
        CutadaptError("Error: cutadapt is not installed\n")

should be at least

def _cutadapt_cmd(params):
    cutadapt_bin = find_executable("cutadapt")
    if cutadapt_bin is None:
        raise CutadaptError("Error: cutadapt is not installed\n")

regards

Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants