Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degree increase/reduction should accept parameter times = 0, which does nothing #6

Open
carlos-adir opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@carlos-adir
Copy link
Collaborator

carlos-adir commented Dec 7, 2023

At the version v1.0.8, calling degree_increase or degree_decrease raises a ValueError when the parameter times = 0 is given.
It should do nothing in that case.

Steps to reproduce:

from compmec.nurbs import Curve

knotvector = (0, 0, 0, 1, 1, 1)  # degree 2, npts 3
curve = Curve(knotvector)
curve.degree_increase(0)  # Raises ValueError
curve.degree_decrease(0)  # Raises ValueError
curve.degree = 2  # Does nothing since degree is already 2
@carlos-adir carlos-adir added the enhancement New feature or request label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant