Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java (OpenJDK) using commonmark-java #342

Open
robinst opened this issue Sep 20, 2024 · 1 comment
Open

Java (OpenJDK) using commonmark-java #342

robinst opened this issue Sep 20, 2024 · 1 comment

Comments

@robinst
Copy link
Collaborator

robinst commented Sep 20, 2024

Since this pull request, Java (OpenJDK) has included a copy of commonmark-java:

When they copied the source files, they made a few adjustments too. There's a list here:

// This module is primarily an import from a recent tagged version of
//     https://github.com/commonmark/commonmark-java
//
// The following parts are imported:
//
// * commonmark/src/main/java
// * commonmark/src/main/resources
// * commonmark-ext-gfm-tables/src/main/java
// * commonmark-ext-gfm-tables/src/main/resources
//
// For source and resource files, the following transformations are applied:
//
// * legal headers are added
// * package and import statements are updated
// * characters outside the ASCII range are converted to Unicode escapes
// * @SuppressWarnings("fallthrough") is added to getSetextHeadingLevel
// * the value for ENTITY_PATH is updated with the modified package
// * the file `entities.properties` is renamed to `entities.txt`

Let's make it easier for them next time by adopting some of the changes.

@robinst
Copy link
Collaborator Author

robinst commented Oct 21, 2024

Hi @jonathan-gibbons! I saw that OpenJDK recently included commonmark-java for Markdown parsing in Javadoc:

Just wanted to recommend upgrading to version 0.24.0, with these changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant