Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-781: Telefonistka wrongly reports "Error" when deploying from a PR branch with auto-sync on #35

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

yzdann
Copy link

@yzdann yzdann commented Oct 25, 2024

Description

  1. User opens a pr
  2. They set the application’s object source to pr branch for an application with autosync enabled
  3. They push another commit

Outcome:
They see an a failed 🔴 telefonistka run with an error like the following:

⚠️ ⚠️ Error getting diff from ArgoCD …

App <x> already has revision <branch> as Source Target Revision and autosync is on, skipping diff calculation

Instead we want to replace the Failing status with Passing status, the Error message with Info message, and avoid showing the Set ArgoCD apps Target Rervision to…

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@yzdann yzdann self-assigned this Oct 28, 2024
@yzdann yzdann marked this pull request as ready for review October 28, 2024 09:20
@yzdann yzdann changed the title Sd 781 SD-781: Telefonistka wrongly reports "Error" when deploying from a PR branch with auto-sync on Oct 28, 2024
@yzdann yzdann merged commit 89c7839 into main Oct 28, 2024
5 checks passed
@hnnsgstfssn hnnsgstfssn mentioned this pull request Oct 28, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants