Improve application diffs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
4 times, most recently
from
d1bf18d to
8e1b400
Compare
hnnsgstfssn
commented
Sep 4, 2024
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
2 times, most recently
from
7f07243 to
1673d32
Compare
hnnsgstfssn
requested review from
a team,
Freyert,
ashvarts,
Oded-B,
yzdann and
jared-logan-patrick-ct
yzdann
previously approved these changes
Sep 5, 2024
sunchill06
previously approved these changes
Sep 5, 2024
ashvarts
previously approved these changes
Sep 5, 2024
hnnsgstfssn
dismissed stale reviews from ashvarts, sunchill06, and yzdann
via
8b8ae5b
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
from
8b8ae5b to
597875f
Compare
yzdann
previously approved these changes
Sep 5, 2024
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
from
597875f to
08be221
Compare
This changes the application diff to render a YAML diff with a number of context lines instead of relying on the cmp library previously used which would render a diff of Go objects.
After discussion it has been deemed unnecessary to enforce non-bare URLs in markdown.
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
from
08be221 to
0bbfab6
Compare
The earlier version fails to run on Darwin with Go 1.23.
hnnsgstfssn
force-pushed
the
SD-407-diff-improvement
branch
from
0bbfab6 to
2bd03ff
Compare
yzdann
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.