Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync PR 2 #14

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Sync PR 2 #14

merged 2 commits into from
Jun 19, 2024

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Jun 19, 2024


Co-authored-by: Hannes Gustafsson [email protected]

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Oded-B and others added 2 commits June 19, 2024 14:43

* Document APPROVER_GITHUB_APP_ID and APPROVER_GITHUB_APP_PRIVATE_KEY_PATH env vars (wayfair-incubator#189)


* Add a Target Description configuration keys to provide control over promotion PR titles (wayfair-incubator#191)

* Add tests for the new **optional** configuration key

* Provide example for PR title in doc

* Allow skipping upstream TLS server certificate validation for the webhook proxy functionality (wayfair-incubator#190)

---------
Co-authored-by: Hannes Gustafsson <[email protected]>
@Oded-B Oded-B marked this pull request as ready for review June 19, 2024 13:04
@Oded-B Oded-B merged commit aa5f386 into main Jun 19, 2024
5 checks passed
Copy link

gitstream-cm bot commented Jun 19, 2024

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

Copy link

gitstream-cm bot commented Jun 19, 2024

🥷 Code experts: no user but you matched threshold 10

Oded-B has most 👩‍💻 activity in the files.
Oded-B has most 🧠 knowledge in the files.

See details

docs/installation.md

Activity based on git-commit:

Oded-B
JUN 1 additions & 0 deletions
MAY 4 additions & 0 deletions
APR 11 additions & 0 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 32%

go.mod

Activity based on git-commit:

Oded-B
JUN 16 additions & 14 deletions
MAY
APR 155 additions & 27 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 81%

go.sum

Activity based on git-commit:

Oded-B
JUN 22 additions & 19 deletions
MAY
APR 1587 additions & 235 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 75%

internal/pkg/configuration/config.go

Activity based on git-commit:

Oded-B
JUN 8 additions & 7 deletions
MAY 1 additions & 0 deletions
APR 5 additions & 3 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 37%

internal/pkg/githubapi/github.go

Activity based on git-commit:

Oded-B
JUN 75 additions & 12 deletions
MAY 8 additions & 1 deletions
APR 51 additions & 10 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 48%

internal/pkg/githubapi/promotion.go

Activity based on git-commit:

Oded-B
JUN 17 additions & 6 deletions
MAY
APR 46 additions & 18 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 26%

internal/pkg/githubapi/promotion_test.go

Activity based on git-commit:

Oded-B
JUN 53 additions & 1 deletions
MAY
APR 47 additions & 0 deletions
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 19%

internal/pkg/githubapi/webhook_proxy.go

Activity based on git-commit:

Oded-B
JUN 1 additions & 1 deletions
MAY
APR
MAR
FEB
JAN

Knowledge based on git-blame:
Oded-B: 100%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant