Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other calendars #17

Open
ahmad-shoja opened this issue Dec 20, 2022 · 12 comments
Open

Support for other calendars #17

ahmad-shoja opened this issue Dec 20, 2022 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@ahmad-shoja
Copy link

Hi, i think we can support other calendar systems by adding another parameter like "dateSystem".
I don't think it requires much changes.
Just adding corresponding year-range, months and days range

@commandiron
Copy link
Owner

Hi, @ahmad-shoja thanks for your feedback. Really can be useful, but which calendars we can add?

@commandiron commandiron added the enhancement New feature or request label Dec 21, 2022
@ahmad-shoja
Copy link
Author

ahmad-shoja commented Dec 21, 2022

To start we can add jallali calendar as I need but there are more systems out there that we can choose popular ones from

@ahmad-shoja
Copy link
Author

Hi, please assign this issue to me I can add this feature.

@commandiron
Copy link
Owner

hi, can't u create pull-request for this?

@ahmad-shoja
Copy link
Author

yeah, why not , I'll create pull-request

@commandiron
Copy link
Owner

this branch is created for this issue.

@commandiron
Copy link
Owner

@ahmad-shoja hi. i can't import PersianDate class for a reason I don't know

@ahmad-shoja
Copy link
Author

Hi @commandiron did you add it's dependency in build gradle file ?

@commandiron
Copy link
Owner

@ahmad-shoja "saman.zamani.persiandate.PersianDate" this import seems to not correct. I don't understand why. Can u bury this code into the package instead of using library?

@ahmad-shoja
Copy link
Author

Hi, Can you tell what is the problem specifically?
And where do you get stock ?

@ahmad-shoja
Copy link
Author

I buried the library inside the code, please check it out

@ahmad-shoja
Copy link
Author

Hi @commandiron, I pushed my new commits but I can't see them in your development_jalalian_calendar, I'm wondering if i need to open a new pull request or what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants