-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for other calendars #17
Comments
Hi, @ahmad-shoja thanks for your feedback. Really can be useful, but which calendars we can add? |
To start we can add jallali calendar as I need but there are more systems out there that we can choose popular ones from |
Hi, please assign this issue to me I can add this feature. |
hi, can't u create pull-request for this? |
yeah, why not , I'll create pull-request |
this branch is created for this issue. |
@ahmad-shoja hi. i can't import PersianDate class for a reason I don't know |
Hi @commandiron did you add it's dependency in build gradle file ? |
@ahmad-shoja "saman.zamani.persiandate.PersianDate" this import seems to not correct. I don't understand why. Can u bury this code into the package instead of using library? |
Hi, Can you tell what is the problem specifically? |
I buried the library inside the code, please check it out |
Hi @commandiron, I pushed my new commits but I can't see them in your development_jalalian_calendar, I'm wondering if i need to open a new pull request or what? |
Hi, i think we can support other calendar systems by adding another parameter like "dateSystem".
I don't think it requires much changes.
Just adding corresponding year-range, months and days range
The text was updated successfully, but these errors were encountered: