Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety cleanup #1086

Open
2 of 6 tasks
adeebshihadeh opened this issue Oct 3, 2022 · 0 comments
Open
2 of 6 tasks

Safety cleanup #1086

adeebshihadeh opened this issue Oct 3, 2022 · 0 comments

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Oct 3, 2022

  • centralize controls_allowed setting
    • block setting on "no entries", like addr checks, lagging, etc.
  • AddrCheckStruct's mutliple allowed messages is bug prone, e.g. defining the same message on either bus 0 and 2 relies on the relay opening before the checks run
  • TX hook should be a whitelist more explicitly
  • RX hook shouldn't run if msg isn't in AddrCheckStruct and valid
  • move always blocked addresses form forward hook into a function, so that we can check all of them instead of a single one in the relay malfunction checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant