Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace React with something simple #42

Open
adeebshihadeh opened this issue May 29, 2024 · 12 comments · May be fixed by #49, #50, #51, #68 or #69
Open

Replace React with something simple #42

adeebshihadeh opened this issue May 29, 2024 · 12 comments · May be fixed by #49, #50, #51, #68 or #69
Labels
bounty enhancement New feature or request

Comments

@adeebshihadeh
Copy link
Collaborator

adeebshihadeh commented May 29, 2024

Replace next/react/etc with a simpler stack. This will be a try-out for comma connect's next framework.

We care about simplicity, brevity, and performance. Some contenders:

Nice site with benchmarks of a bunch of frameworks: https://krausest.github.io/js-framework-benchmark/current.html


EDIT: Some more context on what we're looking for:

I just wrote comma.ai/leaderboard. It loads instantly; you click refresh and don't even see it load. It has a defined JS-less experience and only uses JS where absolutely necessary. I simply started with vi leaderboard.html and got to work.

It was a joy to write, but there were a few pain points:

  • preview was slow to refresh
  • integrating it with webpack and the rest of the build system
  • development vs production (minified version stripped out some spacing)
@wgenh
Copy link

wgenh commented May 31, 2024

Can you check #43 ?

@adeebshihadeh
Copy link
Collaborator Author

Can you check #43 ?

I updated the description with some more info. Is #43 a step towards that?

@wgenh
Copy link

wgenh commented Jun 3, 2024

Can you check #43 ?

I updated the description with some more info. Is #43 a step towards that?

I think so, the page loads without any js

@yaodingyd
Copy link

I'd like to mention that Astro might be the better fit https://astro.build since it's targeted for content heavy website with slight interactivity , default zero js, and support incrementally adding any js framework component. I don't want to step on anyone's toes though, not sure if this is already locked to anything

@yaodingyd yaodingyd linked a pull request Jun 22, 2024 that will close this issue
@trentrand trentrand linked a pull request Jul 14, 2024 that will close this issue
@trentrand
Copy link

@adeebshihadeh, I submitted #50 to demonstrate the same performance as comma.ai/leaderboard while remaining as React

@Miraj98
Copy link

Miraj98 commented Jul 18, 2024

@adeebshihadeh I have mostly migrated this to plain Typescript + HTML but I had a doubt. Is this still using android-fastboot? Saw some previous issues regarding moving away from fastboot to QDL

@Miraj98 Miraj98 linked a pull request Jul 20, 2024 that will close this issue
@PGuimarais
Copy link

Preact can get the bundle size down substantially whilst maintaining DX

@knownotunknown
Copy link

knownotunknown commented Sep 24, 2024

Hey @adeebshihadeh, not sure if @trentrand's PR #50 might've slipped by you, so just wanted to follow up for him (and me to see if the bounty should still be open).

@c-gamble
Copy link

c-gamble commented Oct 1, 2024

I would like to work on (ideally lock) this bounty. I'm creating a completely from-scratch implementation to give the most performative UX.

@adeebshihadeh
Copy link
Collaborator Author

So this bounty is a combo of exploratory and a hiring challenge, so there's no locks for it. It'll just be closed once we merge something good!

@Technologeek
Copy link

My Take (very early but would like to see if we can take this approach)? #66

@fedyk
Copy link

fedyk commented Nov 20, 2024

An attempt to simplify stack #67. The main idea to have the most direct solution without overheads.

Most of the logic for commaai/flash is browser-related. It's difficult to have a JS-less experience. UI logic is simple, and related parts can be simplified.

fedyk added a commit to fedyk/flash that referenced this issue Nov 21, 2024
@fedyk fedyk linked a pull request Nov 23, 2024 that will close this issue
@uanandaraja uanandaraja linked a pull request Nov 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment