Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"All submissions" page is missing detail links. #3690

Open
chrisvanrun opened this issue Nov 7, 2024 · 6 comments
Open

"All submissions" page is missing detail links. #3690

chrisvanrun opened this issue Nov 7, 2024 · 6 comments

Comments

@chrisvanrun
Copy link
Contributor

Is your feature request related to a problem? Please describe.
An alternative approach to the submissions & evaluations is the All Submissions. However, this seems to be missing some links to the submissions and evaluation details.

Describe the solution you'd like
Add the evaluation & submission links to it, or add a link to the Submissions & Evaluations admin page.

Describe alternatives you've considered
All submissions are a collection of submissions for all phases. As such, it's nice to have them scoped per phase in the challenge admin.

Additional context
In the workshop I saw several users ending up on this page, with a visible error message, but no obvious way to get to the evaluation logs itself.

@chrisvanrun chrisvanrun changed the title All submissions page is missing detail links. "All submissions" page is missing detail links. Nov 7, 2024
@chrisvanrun
Copy link
Contributor Author

Specific, it's the list view under grand-challenge.org/evaluation/submissions/

@jmsmkn
Copy link
Member

jmsmkn commented Nov 7, 2024

There was a reason for this I think, maybe it's to do with the permissions, do challenge participants have permission to view the submission detail page?

@amickan
Copy link
Contributor

amickan commented Nov 8, 2024

Participants can view the submission detail page if the phase is public. They can also see the evaluation if the phase is public and the result is published on the leaderboard. So not all links should be visible always. Might make for a bit of an odd table with partially missing links?

@jmsmkn
Copy link
Member

jmsmkn commented Nov 12, 2024

Should those items be in the list anyway? I thought it would have been controlled with the view_submission permission?

@amickan
Copy link
Contributor

amickan commented Nov 14, 2024

Yes, the table will only contain submissions that the participant has view permission for, but not all of those might have a visible evaluation for the participant.

@jmsmkn
Copy link
Member

jmsmkn commented Nov 14, 2024

But then the evaluations are not displayed in that case either, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants