Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Widget type #3680

Open
amickan opened this issue Nov 1, 2024 · 2 comments
Open

Unknown Widget type #3680

amickan opened this issue Nov 1, 2024 · 2 comments

Comments

@amickan
Copy link
Contributor

amickan commented Nov 1, 2024

Someone failed at selecting an image widget. The url parameters don't contain the widget type for some reason. I can't tell how that happened, or how big of an issue this is. This is the first time it happened in the 2 years since we introduced the widget, but maybe good to play around a bit and see if we can reproduce this corner case?

See https://grand-challenge.sentry.io/issues/6036127845/?project=303639&query=%21logger%3Acsp%20is%3Aunresolved&referrer=issue-stream&statsPeriod=12h&stream_index=1

@amickan
Copy link
Contributor Author

amickan commented Nov 1, 2024

@ammar257ammar you are working on this widget at the moment, maybe you want to take a look?

@amickan
Copy link
Contributor Author

amickan commented Nov 8, 2024

There is not enough information in the sentry issue to reproduce the bug really. All we know is that a GET request was made to the ImageWidgetSelectView with an empty widget_name for interface = __INTERFACE_FIELD__sagittal-t2-prostate-mri. Complete request:
GET '/cases/select-image-widget/?WidgetChoice-__INTERFACE_FIELD__sagittal-t2-prostate-mri=&interface_slug=__INTERFACE_FIELD__sagittal-t2-prostate-mri&help_text=Sagittal%20T2%20MRI%20of%20the%20Prostate&current_value='

Users shouldn't be able to submit without a widget_name, so double check that the form raises an appropriate error in all cases (when left empty initially, upon reload after validation etc). If that all works as expected, I would say let's not worry about it, the code did its job in raising a RunTimeError when no widget is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant