Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soundworks v4 #1

Open
etiennedemoulin opened this issue Oct 29, 2023 · 2 comments
Open

soundworks v4 #1

etiennedemoulin opened this issue Oct 29, 2023 · 2 comments

Comments

@etiennedemoulin
Copy link
Contributor

heiho,
trying the soundworks-electron, super nice !
Because soundworks v4 is type:module, I think we should rename the .electron.js > .electron.cjs to avoid error.
Also the soundworks-template-build command is for soundworks v3, and should be updated for v4.

@b-ma
Copy link
Contributor

b-ma commented Oct 29, 2023

Hey, sure this needs to be updated at some point (not really high priority for me I must admit)

Because soundworks v4 is type:module, I think we should rename the .electron.js > .electron.cjs to avoid error.

Or just rewrite with import & co if electron does not complain

Also the soundworks-template-build command is for soundworks v3, and should be updated for v4.

Yup everything needs to be updated and tested w/ soundworks v4 I guess

etiennedemoulin added a commit to etiennedemoulin/soundworks-electron that referenced this issue Oct 29, 2023
@b-ma
Copy link
Contributor

b-ma commented Oct 30, 2023

hotfix released in @soundworks/[email protected]

Let's keep this open until everything is cleaned up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants