From af4d55a7a9fb15f734800a239a72b50cfc6b0bf7 Mon Sep 17 00:00:00 2001 From: Colin Cornaby Date: Wed, 8 Nov 2023 17:45:30 -0800 Subject: [PATCH] Implementing more review feedback --- .../Plasma/Apps/plClient/Mac-Cocoa/PLSServerStatus.mm | 3 +-- .../FeatureLib/pfMetalPipeline/plMetalPipeline.cpp | 10 ---------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSServerStatus.mm b/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSServerStatus.mm index f1e34e841a..3e21430638 100644 --- a/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSServerStatus.mm +++ b/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSServerStatus.mm @@ -65,8 +65,7 @@ - (void)loadServerStatus NSString* urlString = [NSString stringWithSTString:GetServerStatusUrl()]; NSURL* url = [NSURL URLWithString:urlString]; - if (!url || url.host == nil) - { + if (!url || !url.host) { self.serverStatusString = @""; return; } diff --git a/Sources/Plasma/FeatureLib/pfMetalPipeline/plMetalPipeline.cpp b/Sources/Plasma/FeatureLib/pfMetalPipeline/plMetalPipeline.cpp index 2c4ca4f66c..a89fa96a4b 100644 --- a/Sources/Plasma/FeatureLib/pfMetalPipeline/plMetalPipeline.cpp +++ b/Sources/Plasma/FeatureLib/pfMetalPipeline/plMetalPipeline.cpp @@ -1176,16 +1176,6 @@ void plMetalPipeline::IRenderBufferSpan(const plIcicle& span, hsGDeviceRef* vb, plProfile_EndTiming(RenderBuff); -#if 1 - // Enable this for LayerAnimations, but the timing/speed seems wrong - for (size_t i = 0; i < material->GetNumLayers(); i++) { - plLayerInterface* lay = material->GetLayer(i); - if (lay) { - lay->Eval(fTime, fFrame, 0); - } - } -#endif - // Turn on this spans lights and turn off the rest. ISelectLights(&span, mRef);