refactor: refactor active component logic in playground #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2024 13:40
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abcrane123
approved these changes
Nov 14, 2024
brendan-defi
approved these changes
Nov 14, 2024
alessey
reviewed
Nov 15, 2024
| } | ||
| const ActiveComponent = activeComponent | ||
| ? activeComponentMapping[activeComponent] | ||
| : null; |
There was a problem hiding this comment.
nit: could eliminate your null check below and just return a component that renders null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Logic for determining active component and rendering said component is clunky. This PR moves the architecture to a mapping of components and removes the
renderActiveComponentfunction for improved readability.Notes to reviewers
How has it been tested?