Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alissacrane-cb committed Nov 20, 2024
1 parent 67d1d3b commit 09dfb0d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 21 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"graphql-request": "^6.1.0",
"jsdom": "^24.1.0",
"packemon": "3.3.1",
"permissionless": "^0.2.10",
"react": "^18",
"react-dom": "^18",
"rimraf": "^5.0.5",
Expand Down
4 changes: 2 additions & 2 deletions src/transaction/components/TransactionProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ export function TransactionProvider({

const { switchChainAsync } = useSwitchChain();

// Validate `calls` props
if (!calls && !contracts) {
// Validate `calls` and `contracts` props
if (!contracts && !calls) {
throw new Error(
'Transaction: calls or contracts must be provided as a prop to the Transaction component.',
);
Expand Down
10 changes: 2 additions & 8 deletions src/transaction/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,12 @@ export type SendBatchedTransactionsParams = {
capabilities?: WalletCapabilities;
// biome-ignore lint: cannot find module 'wagmi/experimental/query'
sendCallsAsync: any;
transactions?:
| Call[]
| ContractFunctionParameters[]
| (Call | ContractFunctionParameters)[];
transactions?: (Call | ContractFunctionParameters)[];
};

export type SendSingleTransactionParams = {
sendCallAsync: SendTransactionMutateAsync<Config, unknown> | (() => void);
transactions:
| Call[]
| ContractFunctionParameters[]
| (Call | ContractFunctionParameters)[];
transactions: (Call | ContractFunctionParameters)[];
};

/**
Expand Down
10 changes: 0 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2208,7 +2208,6 @@ __metadata:
graphql-request: "npm:^6.1.0"
jsdom: "npm:^24.1.0"
packemon: "npm:3.3.1"
permissionless: "npm:^0.2.10"
react: "npm:^18"
react-dom: "npm:^18"
rimraf: "npm:^5.0.5"
Expand Down Expand Up @@ -12910,15 +12909,6 @@ __metadata:
languageName: node
linkType: hard

"permissionless@npm:^0.2.10":
version: 0.2.13
resolution: "permissionless@npm:0.2.13"
peerDependencies:
viem: ^2.21.22
checksum: f941956c5f8723c5490843ee2c794ae992f8f6211e8773dd602774955a8d12aee36a262a034344646b27bcdca8d6d3dc91a0a94fb6b0fd3c7929cf5ca4ea2a91
languageName: node
linkType: hard

"picocolors@npm:^1.0.0, picocolors@npm:^1.0.1":
version: 1.0.1
resolution: "picocolors@npm:1.0.1"
Expand Down

0 comments on commit 09dfb0d

Please sign in to comment.