Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Pass Config Dict to Business Logic #213

Open
wasciutto opened this issue Jun 15, 2022 · 1 comment
Open

Do Not Pass Config Dict to Business Logic #213

wasciutto opened this issue Jun 15, 2022 · 1 comment
Labels
postprocess2 Issues related to the new postprocessing pipeline

Comments

@wasciutto
Copy link
Contributor

Currently, the controller methods read the configuration file and pass this configuration dictionary to the business functions.

This creates a sprawl of difficult to maintain dictionary key references in sub-methods that can be avoided by just passing in these configuration options as individual arguments.

I originally did not want to deal with a large number of arguments from configuration, but I think unpacking the config dict is ultimately the better call after dealing with the codebase for a while.

This will entail a decent-sized refactor where I would want some overall-pipeline level tests available first.

@wasciutto wasciutto added the enhancement New feature or request label Jun 15, 2022
@wasciutto
Copy link
Contributor Author

May use configuration object here

@wasciutto wasciutto changed the title postproc2: Do Not Pass Config Dict to Business Logic Do Not Pass Config Dict to Business Logic May 11, 2023
@wasciutto wasciutto added postprocess2 Issues related to the new postprocessing pipeline and removed enhancement New feature or request labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postprocess2 Issues related to the new postprocessing pipeline
Projects
None yet
Development

No branches or pull requests

1 participant