Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad is not horizontally centered in GameResults modal #24

Open
codergautam opened this issue Jan 19, 2024 · 0 comments
Open

Ad is not horizontally centered in GameResults modal #24

codergautam opened this issue Jan 19, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@codergautam
Copy link
Owner

codergautam commented Jan 19, 2024

The ad on the Game Results or end screen isn't always horizontally centered. I've narrowed down the issue to this part of the code added in #23 :

32e0d03#diff-f2286f8bf2376694d9c87b819c26cc746048c6c82427ac6036418b9cf48389a3R56

Sometimes Adinplay serves ads smaller than the one we requested, for example a 728x90 when requesting a 970x90 ad. We need an accurate way of determining what the size of the ad being served is, so that it can be centered properly.

@codergautam codergautam added the good first issue Good for newcomers label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant