Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod][new] types-react: remove deprecated types related to mixins #643

Open
alexbit-codemod opened this issue May 19, 2024 · 5 comments

Comments

@alexbit-codemod
Copy link
Contributor

on behalf of eps1lon:

"ComponentSpec and Mixin are now in create-react-class. It might be easiest to fork the deprecated-prop-types-types but with create-react-class instead of prop-types as the target package.

Needs real world codebase with usage to test on."

Note: The example section helps codemod contributors identify all the transformation patterns that this codemod should handle. Repeat before/after snippets for every transformation example you can find.

Code before transformation

//insert your code before transformation here

Code after transformation

//insert the expected **correct** output here

Applicability Criteria

Which types-react versions include the deprecated pattern?

Additional context or links

Add any other context about the problem here. This might include extra considerations, edge cases, relevant business logic, existing migration guides, relevant links, etc.

@mohab-sameh
Copy link
Contributor

@alexbit-codemod the before/after snippets are placeholders. Is that intentional? I cannot find a reference to:

"ComponentSpec and Mixin are now in create-react-class. It might be easiest to fork the deprecated-prop-types-types but with create-react-class instead of prop-types as the target package.

in the migration doc.

@alexbit-codemod
Copy link
Contributor Author

i might have made a mistake with the link... @eps1lon has a separate repo and list of missing codemods...ill try to get that later

@alexbit-codemod
Copy link
Contributor Author

or maybe you can try to find it yourself

@alexbit-codemod alexbit-codemod changed the title [codemod request] types-react: remove deprecated types related to mixins [codemod][new] types-react: remove deprecated types related to mixins Jun 21, 2024
@mohab-sameh
Copy link
Contributor

I could find the issue in @eps1lon's repo but it also doesn't have context about the before/after. @eps1lon if you can provide them, it would be great. Otherwise, I can investigate.

@eps1lon
Copy link

eps1lon commented Jun 24, 2024

I could find eps1lon/types-react-codemod#361 in @eps1lon's repo but it also doesn't have context about the before/after.

Same as deprecated-prop-types-types but with ComponentSpec and Mixin and create-react-class instead of prop-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants