Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix hardcoded server URLs in client #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] Fix hardcoded server URLs in client #117

wants to merge 3 commits into from

Conversation

virinci
Copy link
Contributor

@virinci virinci commented Aug 8, 2024

No description provided.

@virinci virinci added enhancement New feature or request bugfix Fixing a bug labels Aug 8, 2024
@virinci virinci self-assigned this Aug 8, 2024
This was linked to issues Aug 8, 2024
Fix hardcoded server URLs in client #112
Open
Remove the orphan package-lock.json from the repo root #114
Open
@virinci
Copy link
Contributor Author

virinci commented Aug 8, 2024

Hit a wall trying to fix the URLs in public JS files. Any suggestions?

@virinci
Copy link
Contributor Author

virinci commented Aug 10, 2024

Found a decent approach https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes .
We can pass a data-params attribute to the script tag and access it inside the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@virinci virinci

Labels
bugfix Fixing a bug enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the orphan package-lock.json from the repo root Fix hardcoded server URLs in client
1 participant
@virinci