Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put email sending behind a feature flag #106

Open
aahnik opened this issue May 19, 2024 · 1 comment · May be fixed by #109
Open

Put email sending behind a feature flag #106

aahnik opened this issue May 19, 2024 · 1 comment · May be fixed by #109
Assignees

Comments

@aahnik
Copy link
Contributor

aahnik commented May 19, 2024

  • We can have some environment variable called SEND_EMAILS ( or come up with a better naming convention)
  • in the central app config, read that env var
  • in the mailer module, in mailer service, inside sendMail, if that env var is false, don't add mail job to queue
@Suvansarkar
Copy link
Contributor

Working on it

@Suvansarkar Suvansarkar linked a pull request May 19, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants