Implement syntax checking features #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
worksofliam
changed the title
|
👋 A new build is available for this PR based on c616bff. |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
It sure appears to provide the same syntax check as running the SQL in ACS Run SQL Scripts :-) |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
chrjorgensen
suggested changes
Dec 18, 2024
There was a problem hiding this comment.
@worksofliam Looking good and working fine with most samples. 👍
I found one issue:
- connect to IBM i (7.5 in my test)
- open a new SQL document
- enter the following source:
update qtemp.temp_rcpout
set COL1 = '123'
, COL2 = replace( COL2, 'a', 'A' )
, COL3 = replace( COL3, 'b', 'B' )
, COL4 = 'L'
, COL5 = '/dir1/'
, COL6 = 0- press the button to syntax check
I then get this:
Signed-off-by: worksofliam <[email protected]>
|
@chrjorgensen Have another look. I added some additional logic to handle when the message ID is not returned, which is why you were seeing the blank message. It actually looks like this could be a bug in the system API, and IMO shouldn't be impactful to this PR. I also made it so |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
@chrjorgensen I added a new VS Code configuration option to determine if warnings should be shown. It is false by default. |
Open
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
…clarity Signed-off-by: worksofliam <[email protected]>
…ent retrieval Signed-off-by: worksofliam <[email protected]>
…ic conditions Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
…nd increment version number Signed-off-by: worksofliam <[email protected]>
…fore processing and improve error handling Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a problem provider that highlights SQL syntax issues and allows for configurable syntax check intervals. This feature will only syntax check as you are typing. If you're working in a document made up of multiple statements, it will only check the statement you're currently working on while you type. You can use the newly added button to check an entire document.
How to test while editing:
Test the Check Syntax button: