Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract script from unit tests #142

Open
jmartini opened this issue Aug 14, 2018 · 0 comments
Open

Extract script from unit tests #142

jmartini opened this issue Aug 14, 2018 · 0 comments
Assignees
@wesdrew
Labels
testing

Comments

@jmartini
Copy link
Collaborator

Our unit tests currently heavily rely on checking the output script, which has the potential to change often. We should either write tests that don't rely on the speech output OR extract the speech into a speech constants file(s) so production code and test code can reference the same script.
@wesdrew wesdrew self-assigned this Aug 16, 2018
wesdrew added a commit that referenced this issue Sep 19, 2018
@wesdrew
Refactor Intents To Use String Constants
70ef2d5 
References issue #142

Moves strings in intents to string constants to make tests less brittle.
@wesdrew wesdrew mentioned this issue Sep 19, 2018
Merged
wesdrew added a commit that referenced this issue Sep 26, 2018
@wesdrew
Refactor Intents To Use String Constants (#163)
6464529 
References issue #142

Moves strings in intents to string constants to make tests less brittle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesdrew wesdrew

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmartini @curranjm @wesdrew