Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish for Home Page #231

Open
jedpittman opened this issue Dec 23, 2020 · 2 comments
Open

Polish for Home Page #231

jedpittman opened this issue Dec 23, 2020 · 2 comments

Comments

@jedpittman
Copy link
Collaborator

jedpittman commented Dec 23, 2020

Context: We're still seeing lots of text after the user initially selects the occupation. Instead, the user should see the intro text shrink to two lines and end with an ellipsis (...) . Then if the user wants, she can expand the full text again with a caret.

Note: An acceptable implementation is to collapse the entire paragraph with the existing caret. Instead, if possible, from a design perspective, it would be more desirable to leave the top two lines; but if this is too much, implementer has discretion.

Here's the part of the page we're describing:
image

And this would disappear on selection of an occupation:
image

@edward-malouf
Copy link
Collaborator

Here are two screenshots of the page conditions.
Screen Shot 2020-12-22 at 7 47 01 PM
Screen Shot 2020-12-22 at 7 47 10 PM

Here is the link to the Figma
https://www.figma.com/file/RXkmrydtGk66Z3X0AbbKNZ/JoHo-Interface-3?node-id=2%3A40

@jedpittman
Copy link
Collaborator Author

Unassigning @azheng1991 because we're deprioritizing this work for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants