Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closure library support? #2

Open
dylanvaughn opened this issue Dec 28, 2011 · 1 comment
Open

Closure library support? #2

dylanvaughn opened this issue Dec 28, 2011 · 1 comment

Comments

@dylanvaughn
Copy link

Great project! Is there support for using this with Closure Library? I noticed the generated JS doesn't have the Closure Library namespaces at the tops of the files, which are necessary for use with the dependency framework of Closure Library.

Also, I don't believe the Closure Compiler can resolve dependencies / minify Javascript if it is served from a URL instead of being on disk.

I noticed in the code there is a TODO for allowing JS complication options to be passed in. I think this would take care of the first part of this issue. There should also be an option / management URL to write the JS files to the host server's disk for complication with the Google Compiler.

I can start hacking on these issues to fit my needs but I wanted to get your thoughts first. Let me know what you think...

Dylan

@codedance
Copy link
Owner

Sorry for the slow reply. Was off sailing over the Christmas/New Year period! Back into the computers now.

Regarding the TODO for adding JS compile options. My thoughts were to have a servlet/config option (a config string) that would modify the JS compile behaviour. There are potentially a lot of options so one thought was to map the config string to method names via reflection.

Regarding writing compiled files to disk. I'd like to hear more about this (the use case).

I'm keen to support any work that fits within the project's goal ... a nicer tasting tofu :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants